From 0628f768e2d5df84e77032821ed324f67e52e7f9 Mon Sep 17 00:00:00 2001 From: Eric Wasylishen Date: Sat, 29 Apr 2023 12:26:48 -0600 Subject: [PATCH] qbsp: minor clarification in SplitBrush --- qbsp/brushbsp.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qbsp/brushbsp.cc b/qbsp/brushbsp.cc index fc075f82..608c7c73 100644 --- a/qbsp/brushbsp.cc +++ b/qbsp/brushbsp.cc @@ -410,11 +410,11 @@ static twosided SplitBrush( twosided result; // check all points - vec_t d_front = 0; - vec_t d_back = 0; + vec_t d_front = 0; // for points above plane, greatest distance from plane (positive) + vec_t d_back = 0; // for points below plane, greatest distance from plane (negative) for (auto &face : brush->sides) { - for (int j = 0; j < face.w.size(); j++) { - vec_t d = qv::dot(face.w[j], split.normal) - split.dist; + for (const qvec3d &p : face.w) { + vec_t d = split.dist_above(p); if (d > 0 && d > d_front) d_front = d; if (d < 0 && d < d_back)