From 2264de71a260ca038c3c3e482fe831c986b840a1 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Sun, 26 Jun 2022 01:24:47 -0400 Subject: [PATCH] Revert "very slight speedup (~3% improvement) on normalize; don't sqrt if we don't need to (rare), and use multiplication instead of division" This reverts commit 8fe525f5b2b5dac2ced8bd22804007c0ea85382f. --- include/common/qvec.hh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/common/qvec.hh b/include/common/qvec.hh index 614d69ad..0747a051 100644 --- a/include/common/qvec.hh +++ b/include/common/qvec.hh @@ -420,23 +420,23 @@ template template [[nodiscard]] inline qvec normalize(const qvec &v1, T &len) { - len = length2(v1); - return len ? (v1 * (1.0 / std::sqrt(len))) : v1; + len = length(v1); + return len ? (v1 / len) : v1; } template [[nodiscard]] inline qvec normalize(const qvec &v1) { - T len = length2(v1); - return len ? (v1 * (1.0 / std::sqrt(len))) : v1; + T len = length(v1); + return len ? (v1 / len) : v1; } template inline T normalizeInPlace(qvec &v1) { - T len = length2(v1); + T len = length(v1); if (len) { - v1 *= (1.0 / std::sqrt(len)); + v1 /= len; } return len; }