olegpz
/
ericw-tools
mirror of https://github.com/ericwa/ericw-tools.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove unused code related to "no_phong"

This commit is contained in:
Eric Wasylishen 2025-02-08 16:03:46 -07:00
parent cd7968322f
commit 2d54b3409a
4 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/common/bspfile_common.hh
View File

@ -270,9 +270,6 @@ struct surfflags_t
// don't expand this face for larger clip hulls // don't expand this face for larger clip hulls
bool no_expand : 1; bool no_expand : 1;
// block any way phong can be enabled
bool no_phong : 1;
// this face doesn't receive light // this face doesn't receive light
bool light_ignore : 1; bool light_ignore : 1;

3
light/light.cc
View File

@ -1051,9 +1051,6 @@ static void LoadExtendedTexinfoFlags(const fs::path &sourcefilename, const mbsp_
if (val.contains("no_expand")) { if (val.contains("no_expand")) {
flags.no_expand = val.at("no_expand").get<bool>(); flags.no_expand = val.at("no_expand").get<bool>();
} }
if (val.contains("no_phong")) {
flags.no_expand = val.at("no_phong").get<bool>();
}
if (val.contains("light_ignore")) { if (val.contains("light_ignore")) {
flags.light_ignore = val.at("light_ignore").get<bool>(); flags.light_ignore = val.at("light_ignore").get<bool>();
} }

6
light/phong.cc
View File

@ -483,9 +483,6 @@ void CalculateVertexNormals(const mbsp_t *bsp)
if (!f_wants_phong) if (!f_wants_phong)
continue; continue;
if (extended_texinfo_flags[f.texinfo].no_phong)
continue;
for (int j = 0; j < f.numedges; j++) { for (int j = 0; j < f.numedges; j++) {
const int v = Face_VertexAtIndex(bsp, &f, j); const int v = Face_VertexAtIndex(bsp, &f, j);
// walk over all faces incident to f (we will walk over neighbours multiple times, doesn't matter) // walk over all faces incident to f (we will walk over neighbours multiple times, doesn't matter)
@ -509,9 +506,6 @@ void CalculateVertexNormals(const mbsp_t *bsp)
if (!f2_wants_phong) if (!f2_wants_phong)
continue; continue;
if (extended_texinfo_flags[f2->texinfo].no_phong)
continue;
auto *f2_texinfo = Face_Texinfo(bsp, f2); auto *f2_texinfo = Face_Texinfo(bsp, f2);
if (f2_texinfo != nullptr && f_texinfo != nullptr) { if (f2_texinfo != nullptr && f_texinfo != nullptr) {
if (!bsp->loadversion->game->surfflags_may_phong(f_texinfo->flags, f2_texinfo->flags)) { if (!bsp->loadversion->game->surfflags_may_phong(f_texinfo->flags, f2_texinfo->flags)) {

3
qbsp/writebsp.cc
View File

@ -395,9 +395,6 @@ static void WriteExtendedTexinfoFlags()
if (tx.flags.no_expand) { if (tx.flags.no_expand) {
t["no_expand"] = tx.flags.no_expand; t["no_expand"] = tx.flags.no_expand;
} }
if (tx.flags.no_phong) {
t["no_phong"] = tx.flags.no_phong;
}
if (tx.flags.light_ignore) { if (tx.flags.light_ignore) {
t["light_ignore"] = tx.flags.light_ignore; t["light_ignore"] = tx.flags.light_ignore;
} }