From 41de747a9abdfe5764dc8e2949a02223387d5711 Mon Sep 17 00:00:00 2001 From: Eric Wasylishen Date: Thu, 1 Dec 2022 01:20:59 -0700 Subject: [PATCH] qbsp: for "Q2 phong (value set, LIGHT unset) used on a mirrored face." warning, don't set value to 0 - setting value to 0 was not a robust way to disable phong - it could actually have the reverse effect if "value 1" was being used to change a smoothing group, setting value back to 0 could reintroduce unwanted smoothing - that hack should be less useful with the phong system improvements in the previous commits --- qbsp/map.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qbsp/map.cc b/qbsp/map.cc index a1d78cd2..fc630d30 100644 --- a/qbsp/map.cc +++ b/qbsp/map.cc @@ -1653,8 +1653,7 @@ static void ParseTextureDef(parser_t &parser, mapface_t &mapface, const mapbrush const bool mirrored = (extinfo.info->contents.native != 0) && !(extinfo.info->contents.native & (Q2_CONTENTS_SOLID | Q2_CONTENTS_WINDOW)); if (wants_phong && mirrored) { - logging::print("WARNING: {}: Q2 phong (value set, LIGHT unset) used on a mirrored face. Removing phong.\n", mapface.line); - extinfo.info->value = 0; + logging::print("WARNING: {}: Q2 phong (value set, LIGHT unset) used on a mirrored face.\n", mapface.line); } }