From 5c285052d19e65314f54b2f7b2f6979754e6733c Mon Sep 17 00:00:00 2001 From: Eric Wasylishen Date: Sun, 3 Sep 2023 12:46:39 -0600 Subject: [PATCH] lightpreview: note some threading bugs --- lightpreview/mainwindow.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lightpreview/mainwindow.cpp b/lightpreview/mainwindow.cpp index f46e2aa2..548d1f90 100644 --- a/lightpreview/mainwindow.cpp +++ b/lightpreview/mainwindow.cpp @@ -709,16 +709,19 @@ int MainWindow::compileMap(const QString &file, bool is_reload) m_bspdata.loadversion->game->init_filesystem(file.toStdString(), settings); } } catch (const settings::parse_exception &p) { + // FIXME: threading error: don't call Qt widgets code from background thread auto *textEdit = m_outputLogWidget->textEdit(m_activeLogTab); textEdit->append(QString::fromUtf8(p.what()) + QString::fromLatin1("\n")); m_activeLogTab = ETLogTab::TAB_LIGHTPREVIEW; return 1; } catch (const settings::quit_after_help_exception &p) { + // FIXME: threading error: don't call Qt widgets code from background thread auto *textEdit = m_outputLogWidget->textEdit(m_activeLogTab); textEdit->append(QString::fromUtf8(p.what()) + QString::fromLatin1("\n")); m_activeLogTab = ETLogTab::TAB_LIGHTPREVIEW; return 1; } catch (const std::exception &other) { + // FIXME: threading error: don't call Qt widgets code from background thread auto *textEdit = m_outputLogWidget->textEdit(m_activeLogTab); textEdit->append(QString::fromUtf8(other.what()) + QString::fromLatin1("\n")); m_activeLogTab = ETLogTab::TAB_LIGHTPREVIEW;