From 71933f2be1fee65b96abc75fe719517387b159cc Mon Sep 17 00:00:00 2001
From: Eric Wasylishen <ewasylishen@gmail.com>
Date: Sun, 17 Nov 2024 21:34:54 -0700
Subject: [PATCH] cleanup: don't pass double by reference (it's only 8 bytes)

---
 common/mathlib.cc        | 2 +-
 include/common/cmdlib.hh | 2 +-
 include/common/qvec.hh   | 2 +-
 include/qbsp/qbsp.hh     | 3 +--
 qbsp/qbsp.cc             | 6 +-----
 5 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/common/mathlib.cc b/common/mathlib.cc
index 6a4a32c2..77049dc8 100644
--- a/common/mathlib.cc
+++ b/common/mathlib.cc
@@ -600,7 +600,7 @@ std::array<std::pair<qvec2i, float>, 4> bilinearWeightsAndCoords(qvec2f pos, con
  * - the direction doesn't matter.
  * - only tips touching is enough
  */
-bool LinesOverlap(const qvec3f &p0, const qvec3f &p1, const qvec3f &q0, const qvec3f &q1, const double &on_epsilon)
+bool LinesOverlap(const qvec3f &p0, const qvec3f &p1, const qvec3f &q0, const qvec3f &q1, double on_epsilon)
 {
     const float q0_linedist = DistToLine(p0, p1, q0);
     if (q0_linedist > on_epsilon)
diff --git a/include/common/cmdlib.hh b/include/common/cmdlib.hh
index 83855c69..7b5702f2 100644
--- a/include/common/cmdlib.hh
+++ b/include/common/cmdlib.hh
@@ -285,7 +285,7 @@ inline std::ostream &operator<=(std::ostream &s, const float &c)
     return s;
 }
 
-inline std::ostream &operator<=(std::ostream &s, const double &c)
+inline std::ostream &operator<=(std::ostream &s, double c)
 {
     if (!detail::need_swap(s))
         s.write(reinterpret_cast<const char *>(&c), sizeof(c));
diff --git a/include/common/qvec.hh b/include/common/qvec.hh
index 33f3ee67..fdcb08dc 100644
--- a/include/common/qvec.hh
+++ b/include/common/qvec.hh
@@ -1178,7 +1178,7 @@ std::vector<V> PointsAlongLine(const V &start, const V &end, const float step)
 }
 
 bool LinesOverlap(const qvec3f &p0, const qvec3f &p1, const qvec3f &q0, const qvec3f &q1,
-    const double &on_epsilon = DEFAULT_ON_EPSILON);
+    double on_epsilon = DEFAULT_ON_EPSILON);
 
 template<typename T>
 struct twosided
diff --git a/include/qbsp/qbsp.hh b/include/qbsp/qbsp.hh
index 4e8c8ddd..f4e58397 100644
--- a/include/qbsp/qbsp.hh
+++ b/include/qbsp/qbsp.hh
@@ -337,8 +337,7 @@ public:
     [[nodiscard]] qbsp_plane_t operator-() const;
 
     [[nodiscard]] const plane_type_t &get_type() const;
-    [[nodiscard]] const double &get_dist() const;
-    [[nodiscard]] double &get_dist();
+    [[nodiscard]] double get_dist() const;
     [[nodiscard]] const qvec3d &get_normal() const;
     bool set_normal(const qvec3d &vec, bool flip = false);
     bool set_plane(const qplane3d &plane, bool flip = false);
diff --git a/qbsp/qbsp.cc b/qbsp/qbsp.cc
index 33dec578..b7ea8dec 100644
--- a/qbsp/qbsp.cc
+++ b/qbsp/qbsp.cc
@@ -321,11 +321,7 @@ qbsp_plane_t &qbsp_plane_t::operator=(const qplane3d &plane) noexcept
 {
     return type;
 }
-[[nodiscard]] const double &qbsp_plane_t::get_dist() const
-{
-    return plane.dist;
-}
-[[nodiscard]] double &qbsp_plane_t::get_dist()
+[[nodiscard]] double qbsp_plane_t::get_dist() const
 {
     return plane.dist;
 }