From 8d51e23ecc4963892cf4e376cd78c33971882b46 Mon Sep 17 00:00:00 2001 From: Eric Wasylishen Date: Tue, 21 Sep 2021 00:09:55 -0600 Subject: [PATCH] bspfile: add fixme about q2 overflow checking --- common/bspfile.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/bspfile.cc b/common/bspfile.cc index c77b1954..503f1720 100644 --- a/common/bspfile.cc +++ b/common/bspfile.cc @@ -2716,6 +2716,9 @@ ConvertBSPFormat(bspdata_t *bspdata, const bspversion_t *to_version) const mbsp_t *mbsp = &bspdata->data.mbsp; q2bsp_t *q2bsp = &bspdata->data.q2bsp; + // FIXME: validate that the conversion is possible without overflow + // (see bspver_q1 case above) + memset(q2bsp, 0, sizeof(*q2bsp)); // copy counts