From 8dab875adc68a763cf5a36a353cb29d6de0db3fb Mon Sep 17 00:00:00 2001
From: Eric Wasylishen <ewasylishen@gmail.com>
Date: Sun, 18 Sep 2016 17:30:21 -0600
Subject: [PATCH] light: CheckTargets: also check for unmatched targetnames

---
 light/entities.cc | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/light/entities.cc b/light/entities.cc
index dcc31b28..2eeb0ad0 100644
--- a/light/entities.cc
+++ b/light/entities.cc
@@ -156,12 +156,13 @@ MatchTargets(void)
 }
 
 /**
- * Checks `entdicts` for unmatched targets and prints warnings
+ * Checks `entdicts` for unmatched targets/targetnames and prints warnings
  */
 static void
 CheckTargets(void)
 {
-    for (entdict_t &entity : entdicts) {
+    // search for "target" values such that no entity has a matching "targetname"
+    for (const entdict_t &entity : entdicts) {
         const auto targetstr = EntDict_StringForKey(entity, "target");
         if (!targetstr.length())
             continue;
@@ -181,6 +182,28 @@ CheckTargets(void)
                      EntDict_StringForKey(entity, "target").c_str());
         }
     }
+    
+    // search for "targetname" values such that no entity has a matching "target"
+    for (const entdict_t &entity : entdicts) {
+        const auto targetnamestr = EntDict_StringForKey(entity, "targetname");
+        if (!targetnamestr.length())
+            continue;
+        
+        bool found = false;
+        for (const entdict_t &targetter : entdicts) {
+            if (targetnamestr == EntDict_StringForKey(targetter, "target")) {
+                found = true;
+                break;
+            }
+        }
+        
+        if (!found) {
+            logprint("WARNING: entity at (%s) (%s) has targetname '%s' which is not targetted by anything.\n",
+                     EntDict_StringForKey(entity, "origin").c_str(),
+                     EntDict_StringForKey(entity, "classname").c_str(),
+                     targetnamestr.c_str());
+        }
+    }
 }
 
 static void