olegpz
/
ericw-tools
mirror of https://github.com/ericwa/ericw-tools.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qbsp: avoid triggering MSVC std::vector access bounds check 

even though we're just taking the address with &, face->edges[face->w.size()]
was accessing an out-of-bounds element
This commit is contained in:
Eric Wasylishen 2021-10-06 16:44:14 -06:00
parent 0d06489016
commit 9b19828530
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qbsp/surfaces.cc
View File

@ -371,7 +371,7 @@ static void EmitFace(mapentity_t *entity, face_t *face)
// emit surfedges
out.firstedge = static_cast<int32_t>(map.bsp.dsurfedges.size());
std::copy(&face->edges[0], &face->edges[face->w.size()], std::back_inserter(map.bsp.dsurfedges));
std::copy(face->edges.cbegin(), face->edges.cbegin() + face->w.size(), std::back_inserter(map.bsp.dsurfedges));
face->edges.clear();
out.numedges = static_cast<int32_t>(map.bsp.dsurfedges.size()) - out.firstedge;