olegpz
/
ericw-tools
mirror of https://github.com/ericwa/ericw-tools.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qbsp: warn and disable q2-style phong if used on a mirrored face

This commit is contained in:
Eric Wasylishen 2022-11-17 23:51:00 -07:00
parent 328fa6ade6
commit 9c3a807391
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
qbsp/map.cc
View File

@ -1641,6 +1641,19 @@ static void ParseTextureDef(parser_t &parser, mapface_t &mapface, const mapbrush
issue_stats.num_sky_nodraw++;
}
}
// If Q2 style phong is enabled on a mirrored face, `light` will erroneously try to blend normals between
// the front and back faces leading to light artifacts.
const bool wants_phong = !(extinfo.info->flags.native & Q2_SURF_LIGHT)
&& (extinfo.info->value != 0);
// Technically this is not the 100% correct check for mirrored, but we don't have the full brush
// contents set up at this point. Correct would be to call `portal_generates_face()`.
const bool mirrored = (extinfo.info->contents.native != 0)
&& !(extinfo.info->contents.native & (Q2_CONTENTS_SOLID | Q2_CONTENTS_WINDOW));
if (wants_phong && mirrored) {
logging::print("WARNING: {}: Q2 phong (value set, LIGHT unset) used on a mirrored face. Removing phong.\n", mapface.line);
extinfo.info->value = 0;
}
}
tx->miptex = FindMiptex(mapface.texname.c_str(), extinfo.info);