From ab59f5ea3eefeae97e85479358af60bb6aea53cd Mon Sep 17 00:00:00 2001 From: Eric Wasylishen Date: Sun, 1 May 2022 00:13:33 -0600 Subject: [PATCH] testmaps: expand water_detail_illusionary test (failing) --- qbsp/test_qbsp.cc | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/qbsp/test_qbsp.cc b/qbsp/test_qbsp.cc index cb2de862..219df7c2 100644 --- a/qbsp/test_qbsp.cc +++ b/qbsp/test_qbsp.cc @@ -461,13 +461,21 @@ TEST(testmaps_q1, water_detail_illusionary) { const mbsp_t bsp = LoadTestmap("qbsp_water_detail_illusionary.map"); - ASSERT_FALSE(map.leakfile); + EXPECT_FALSE(map.leakfile); const qvec3d inside_water_and_fence{-20, -52, 124}; - const auto *leaf = BSP_FindLeafAtPoint(&bsp, &bsp.dmodels[0], inside_water_and_fence); - ASSERT_EQ(leaf->contents, CONTENTS_WATER); -} + const qvec3d inside_fence{-20, -52, 172}; + EXPECT_EQ(BSP_FindLeafAtPoint(&bsp, &bsp.dmodels[0], inside_water_and_fence)->contents, CONTENTS_WATER); + EXPECT_EQ(BSP_FindLeafAtPoint(&bsp, &bsp.dmodels[0], inside_fence)->contents, CONTENTS_EMPTY); + + const qvec3d underwater_face_pos{-40, -52, 124}; + const qvec3d above_face_pos{-40, -52, 172}; + + // make sure the detail_illusionary face underwater isn't clipped away + EXPECT_NE(nullptr, BSP_FindFaceAtPoint(&bsp, &bsp.dmodels[0], underwater_face_pos, {-1, 0, 0})); + EXPECT_NE(nullptr, BSP_FindFaceAtPoint(&bsp, &bsp.dmodels[0], above_face_pos, {-1, 0, 0})); +} TEST(testmaps_q1, noclipfaces) {