From c78a911611b3c637025191403fd00fbe004d20d8 Mon Sep 17 00:00:00 2001
From: Eric Wasylishen <ewasylishen@gmail.com>
Date: Fri, 15 Apr 2022 02:33:08 -0600
Subject: [PATCH] qbsp: add fixme

---
 qbsp/surfaces.cc                 |  3 +++
 testmaps/qbsp_simple_sealed2.map | 38 +++++++++++++++++++++++++++++++-
 2 files changed, 40 insertions(+), 1 deletion(-)

diff --git a/qbsp/surfaces.cc b/qbsp/surfaces.cc
index ef3d7993..8067da57 100644
--- a/qbsp/surfaces.cc
+++ b/qbsp/surfaces.cc
@@ -560,6 +560,9 @@ static void AddFaceToTree_r(mapentity_t* entity, face_t *face, brush_t *srcbrush
                 }
             }
         }
+
+        // fixme-brushbsp: need to continue clipping it down the bsp tree,
+        // this currently leaves bits floating in the void that happen to touch splitting nodes
         
         return;
     }
diff --git a/testmaps/qbsp_simple_sealed2.map b/testmaps/qbsp_simple_sealed2.map
index 1aa412c1..c761754b 100644
--- a/testmaps/qbsp_simple_sealed2.map
+++ b/testmaps/qbsp_simple_sealed2.map
@@ -81,7 +81,7 @@
 }
 // brush 8
 {
-( -128 -384 48 ) ( -128 -368 48 ) ( -128 -384 208 ) orangestuff8 [ 0 -1 0 0 ] [ -0 -0 -1 0 ] 0 2 2
+( -352 -384 48 ) ( -352 -368 48 ) ( -352 -384 208 ) orangestuff8 [ 0 -1 0 0 ] [ -0 -0 -1 0 ] 0 2 2
 ( -16 -384 48 ) ( -240 -384 48 ) ( -16 -384 208 ) orangestuff8 [ 1 0 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
 ( -16 -384 48 ) ( -16 -368 48 ) ( -240 -384 48 ) orangestuff8 [ -1 0 0 0 ] [ -0 -1 -0 0 ] 0 2 2
 ( -240 -384 208 ) ( -240 -368 208 ) ( -16 -384 208 ) orangestuff8 [ 1 0 0 0 ] [ 0 -1 0 0 ] 0 2 2
@@ -97,6 +97,42 @@
 ( -128 -208 48 ) ( 96 -208 48 ) ( -128 -208 208 ) orangestuff8 [ -1 0 0 0 ] [ 0 0 -1 0 ] 0 2 2
 ( 0 -368 208 ) ( 0 -352 208 ) ( 0 -368 48 ) orangestuff8 [ 0 1 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
 }
+// brush 10
+{
+( 144 -192 48 ) ( 144 -176 48 ) ( 144 -192 208 ) orangestuff8 [ 0 -1 0 0 ] [ -0 -0 -1 0 ] 0 2 2
+( 256 -208 48 ) ( 32 -208 48 ) ( 256 -208 208 ) orangestuff8 [ 1 0 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
+( 256 -192 48 ) ( 256 -176 48 ) ( 32 -192 48 ) orangestuff8 [ -1 0 0 0 ] [ -0 -1 -0 0 ] 0 2 2
+( 32 -192 208 ) ( 32 -176 208 ) ( 256 -192 208 ) orangestuff8 [ 1 0 0 0 ] [ 0 -1 0 0 ] 0 2 2
+( 32 -176 48 ) ( 256 -176 48 ) ( 32 -176 208 ) orangestuff8 [ -1 0 0 0 ] [ 0 0 -1 0 ] 0 2 2
+( 256 -192 208 ) ( 256 -176 208 ) ( 256 -192 48 ) orangestuff8 [ 0 1 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
+}
+// brush 11
+{
+( 288 -192 48 ) ( 288 -176 48 ) ( 288 -192 208 ) orangestuff8 [ 0 -1 0 0 ] [ -0 -0 -1 0 ] 0 2 2
+( 400 -208 48 ) ( 176 -208 48 ) ( 400 -208 208 ) orangestuff8 [ 1 0 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
+( 400 -192 48 ) ( 400 -176 48 ) ( 176 -192 48 ) orangestuff8 [ -1 0 0 0 ] [ -0 -1 -0 0 ] 0 2 2
+( 176 -192 208 ) ( 176 -176 208 ) ( 400 -192 208 ) orangestuff8 [ 1 0 0 0 ] [ 0 -1 0 0 ] 0 2 2
+( 176 -176 48 ) ( 400 -176 48 ) ( 176 -176 208 ) orangestuff8 [ -1 0 0 0 ] [ 0 0 -1 0 ] 0 2 2
+( 400 -192 208 ) ( 400 -176 208 ) ( 400 -192 48 ) orangestuff8 [ 0 1 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
+}
+// brush 12
+{
+( 16 -272 48 ) ( 16 -256 48 ) ( 16 -272 208 ) orangestuff8 [ 0 -1 0 0 ] [ -0 -0 -1 0 ] 0 2 2
+( 96 -288 48 ) ( -128 -288 48 ) ( 96 -288 208 ) orangestuff8 [ 1 0 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
+( 96 -272 48 ) ( 96 -256 48 ) ( -128 -272 48 ) orangestuff8 [ -1 0 0 0 ] [ -0 -1 -0 0 ] 0 2 2
+( -128 -272 208 ) ( -128 -256 208 ) ( 96 -272 208 ) orangestuff8 [ 1 0 0 0 ] [ 0 -1 0 0 ] 0 2 2
+( -128 -256 48 ) ( 96 -256 48 ) ( -128 -256 208 ) orangestuff8 [ -1 0 0 0 ] [ 0 0 -1 0 ] 0 2 2
+( 96 -272 208 ) ( 96 -256 208 ) ( 96 -272 48 ) orangestuff8 [ 0 1 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
+}
+// brush 13
+{
+( 96 -320 48 ) ( 96 -304 48 ) ( 96 -320 208 ) orangestuff8 [ 0 -1 0 0 ] [ -0 -0 -1 0 ] 0 2 2
+( 176 -336 48 ) ( -48 -336 48 ) ( 176 -336 208 ) orangestuff8 [ 1 0 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
+( 176 -320 48 ) ( 176 -304 48 ) ( -48 -320 48 ) orangestuff8 [ -1 0 0 0 ] [ -0 -1 -0 0 ] 0 2 2
+( -48 -320 208 ) ( -48 -304 208 ) ( 176 -320 208 ) orangestuff8 [ 1 0 0 0 ] [ 0 -1 0 0 ] 0 2 2
+( -48 -304 48 ) ( 176 -304 48 ) ( -48 -304 208 ) orangestuff8 [ -1 0 0 0 ] [ 0 0 -1 0 ] 0 2 2
+( 176 -320 208 ) ( 176 -304 208 ) ( 176 -320 48 ) orangestuff8 [ 0 1 -0 0 ] [ 0 -0 -1 0 ] 0 2 2
+}
 }
 // entity 1
 {