olegpz
/
ericw-tools
mirror of https://github.com/ericwa/ericw-tools.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: add a consistency check that face winding order is consistent with plane normal

This commit is contained in:
Eric Wasylishen 2023-12-03 15:30:03 -07:00
parent 05ae8b0d19
commit e07f76cf75
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tests/test_qbsp.cc
View File

@ -33,6 +33,27 @@ const mapface_t *Mapbrush_FirstFaceWithTextureName(const mapbrush_t &brush, cons
return nullptr;
}
void CheckFaceNormal(const mbsp_t *bsp, const mface_t *face)
{
qvec3d face_normal_from_plane = Face_Normal(bsp, face);
auto winding = Face_Winding(bsp, face);
winding.remove_colinear();
if (winding.size() < 3)
return;
auto winding_plane = winding.plane();
CHECK(qv::dot(face_normal_from_plane, winding_plane.normal) > 0.0);
}
void CheckBsp(const mbsp_t *bsp)
{
for (const mface_t &face : bsp->dfaces) {
CheckFaceNormal(bsp, &face);
}
}
mapentity_t &LoadMap(const char *map, size_t length)
{
::map.reset();
@ -121,6 +142,8 @@ std::tuple<mbsp_t, bspxentries_t, std::optional<prtfile_t>> LoadTestmap(
ConvertBSPFormat(&bspdata, &bspver_generic);
CheckBsp(&std::get<mbsp_t>(bspdata.bsp));
// write to .json for inspection
serialize_bsp(
bspdata, std::get<mbsp_t>(bspdata.bsp), fs::path(qbsp_options.bsp_path).replace_extension(".bsp.json"));