olegpz
/
ericw-tools
mirror of https://github.com/ericwa/ericw-tools.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix missing move 

fix clip_back causing extra copies
This commit is contained in:
Jonathan 2022-08-12 02:03:00 -04:00
parent bf162c7a86
commit ea38e5eeb7
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/common/polylib.hh
View File

@ -1124,7 +1124,7 @@ public:
==================
*/
std::optional<winding_base_t> clip_back(
const qplane3d &plane, const vec_t &on_epsilon = DEFAULT_ON_EPSILON, const bool &keepon = false) const
const qplane3d &plane, const vec_t &on_epsilon = DEFAULT_ON_EPSILON, const bool &keepon = false)
{
vec_t *dists = (vec_t *)alloca(sizeof(vec_t) * (size() + 1));
planeside_t *sides = (planeside_t *)alloca(sizeof(planeside_t) * (size() + 1));

2
qbsp/brushbsp.cc
View File

@ -513,7 +513,7 @@ static twosided<bspbrush_t::ptr> SplitBrush(bspbrush_t::ptr brush, size_t planen
// add the clipped face to result[j]
side_t faceCopy = face;
faceCopy.w = *cw[j];
faceCopy.w = std::move(*cw[j]);
// fixme-brushbsp: configure any settings on the faceCopy?
// Q2 does `cs->tested = false;`, why?