From ff2ff5c87f500118ac18c1a9df35cc48c5d98d67 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Tue, 25 Jan 2022 04:21:07 -0500 Subject: [PATCH] fix emplace UB --- include/common/polylib.hh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/common/polylib.hh b/include/common/polylib.hh index ec74114a..a76a4f8c 100644 --- a/include/common/polylib.hh +++ b/include/common/polylib.hh @@ -303,7 +303,7 @@ public: { // move us to dynamic if (count == N) - data.template emplace(begin(), end()); + data = vector_type(begin(), end()); if (is_dynamic()) std::get(data).push_back(vec); @@ -317,8 +317,9 @@ public: { // move us to dynamic if we'll expand too big if (new_size > N && !is_dynamic()) { - auto &vector = data.template emplace(begin(), end()); + auto &vector = vector_type(begin(), end()); vector.resize(new_size); + data = std::move(vector); } else if (is_dynamic()) { if (new_size > N) std::get(data).resize(new_size);