ua1zbe
/
aprsc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a couple of small memory leaks, which may happen in error cases when loading configuration

This commit is contained in:
Heikki Hannikainen 2016-08-13 16:22:08 +03:00
parent d49d7bfeb0
commit b8cdf3cbe4
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/acl.c
View File

@ -122,6 +122,8 @@ int acl_add(struct acl_t *acl, char *netspec, int allow)
prefixlen = atoi(prefixls);
if (prefixlen < 0 || prefixlen > 128) {
hlog(LOG_ERR, "ACL: invalid prefix len '%s' for '%s'", prefixls, netspec);
if (ai)
freeaddrinfo(ai);
return -1;
}
}
@ -179,7 +181,7 @@ int acl_add(struct acl_t *acl, char *netspec, int allow)
}
hfree(addr_s);
hfree(ai);
freeaddrinfo(ai);
ai = nextai;
}

6
src/config.c
View File

@ -489,6 +489,8 @@ int do_peergroup(struct peerip_config_t **lq, int argc, char **argv)
char *peerid = NULL;
char *fullhost, *host_s, *port_s;
int af;
ai = my_ai = a = NULL;
if (argc < 4)
return -1;
@ -535,6 +537,7 @@ int do_peergroup(struct peerip_config_t **lq, int argc, char **argv)
if (d != 1) {
hlog(LOG_ERR, "PeerGroup: address parsing for local address %s returned %d addresses - can only have one", fullhost, d);
hfree(fullhost);
freeaddrinfo(my_ai);
return -2;
}
@ -626,6 +629,7 @@ int do_peergroup(struct peerip_config_t **lq, int argc, char **argv)
fullhost = NULL;
hfree(peerid);
freeaddrinfo(ai);
ai = NULL;
continue;
}
@ -665,6 +669,8 @@ err:
hfree(fullhost);
if (peerid)
hfree(peerid);
if (ai)
freeaddrinfo(ai);
return -2;
}