ua1zbe
/
aprsc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

outgoing: reorder checks to do the more common ones first

This commit is contained in:
Heikki Hannikainen 2012-10-12 00:12:08 +03:00
parent bb86d0f733
commit c17fd235a0
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/outgoing.c
View File

@ -42,6 +42,14 @@ static void process_outgoing_single(struct worker_t *self, struct pbuf_t *pb)
for (c = self->clients; (c); c = cnext) {
cnext = c->next; // client_write() MAY destroy the client object!
/* more likely checks first */
if ((pb->flags & F_DUPE) && (!(c->flags & CLFLAGS_DUPEFEED))) {
/* Duplicate packet.
Don't send, unless client especially wants! */
//hlog(LOG_DEBUG, "%d: not sending to client: packet is duplicate", c->fd);
continue;
}
/* Do not send to clients that are not logged in. */
if (c->state != CSTATE_CONNECTED && c->state != CSTATE_COREPEER) {
//hlog(LOG_DEBUG, "%d/%s: not sending to client: not connected", c->fd, c->username);
@ -67,19 +75,7 @@ static void process_outgoing_single(struct worker_t *self, struct pbuf_t *pb)
continue;
}
if ((pb->flags & F_DUPE) && (!(c->flags & CLFLAGS_DUPEFEED))) {
/* Duplicate packet.
Don't send, unless client especially wants! */
//hlog(LOG_DEBUG, "%d: not sending to client: packet is duplicate", c->fd);
continue;
}
if (c->flags & CLFLAGS_DUPEFEED) {
/* Duplicate packets feed? Don't send unless the packet is a duplicate. */
if (!(pb->flags & F_DUPE)) {
continue;
}
} else if (c->flags & CLFLAGS_INPORT) {
if (c->flags & CLFLAGS_INPORT) {
/* Downstream client? If not full feed, process filters
* to see if the packet should be sent.
*/
@ -95,6 +91,11 @@ static void process_outgoing_single(struct worker_t *self, struct pbuf_t *pb)
//hlog(LOG_DEBUG, "fd %d: Not from downstr, not sending to upstr.", c->fd);
continue;
}
} else if (c->flags & CLFLAGS_DUPEFEED) {
/* Duplicate packets feed? Don't send unless the packet is a duplicate. */
if (!(pb->flags & F_DUPE)) {
continue;
}
} else {
hlog(LOG_DEBUG, "fd %d: Odd! Client not upstream or downstream. Not sending packets.", c->fd);
continue;