ua1zbe
/
aprsc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

incoming srccall check: relax SSID length requirement a bit to match javap3 for now

This commit is contained in:
Heikki Hannikainen 2013-04-18 23:04:40 +03:00
parent ce78e927dd
commit ca13794f61
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/incoming.c
View File

@ -534,8 +534,13 @@ int check_invalid_src_dst(const char *call, int len)
i++;
/* Check SSID length to be between 1 and 2 */
/* javap4 drops these, javap3 allows, consider to drop later
if (len - i > 2 || len == i)
return -1;
*/
/* Check SSID length to be at least 1 */
if (len == i)
return -1;
/* SSID of 0? */
/* Is allowed in javaprssrvr

5
tests/t/11misc-drops.t
View File

@ -78,9 +78,10 @@ my @pkts = (
"SRC2>DST,DIGI,TCPXX,qAR,$login:>Packet from unverified login according to TCPXX in path",
"SRC2>DST,DIGI,TCPXX*,qAR,$login:>Packet from unverified login according to TCPXX* in path",
"SRC->DST,DIGI-0,qAR,$login:>should drop, too short SSID in srccall",
"SRC-111>DST,DIGI-0,qAR,$login:>should drop, too long SSID in srccall",
"EL-DH5FFL>DST,DIGI-0,qAR,$login:>should drop, much too long SSID in srccall",
"SRC>DST,DIGI-0,qAR,$login:>should drop, -0 SSID in viacall",
# javap4 drops these, javap3 allows
# "SRC-111>DST,DIGI-0,qAR,$login:>should drop, too long SSID in srccall",
# "EL-DH5FFL>DST,DIGI-0,qAR,$login:>should drop, much too long SSID in srccall",
);
# send the packets