Performance fix in _findBookmark(), some comments.

This commit is contained in:
Marat Fayzullin 2023-07-04 18:40:40 -04:00
parent 3ab19d5f37
commit 645b057d49
2 changed files with 2 additions and 1 deletions

View File

@ -119,6 +119,7 @@ class Bookmarks(object):
return result
def getEditableBookmarks(self):
# Only return bookmarks that can be saved
self._refresh()
return [b for b in self.bookmarks if b.srcFile is None]

View File

@ -86,7 +86,7 @@ class BookmarksController(AuthorizationMixin, BreadcrumbMixin, WebpageController
def _findBookmark(self, bookmark_id):
bookmarks = Bookmarks.getSharedInstance()
try:
return next(b for b in bookmarks.getEditableBookmarks() if id(b) == bookmark_id)
return next(b for b in bookmarks.getBookmarks() if id(b) == bookmark_id)
except StopIteration:
return None