diff --git a/CHANGELOG.md b/CHANGELOG.md index bc8c49a0..9b29d6c6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ **1.2.67** - Added keyboard shortcuts (press [?] for help). +- Added range check to the FFT overlap parameter. **1.2.66** - Added bookmark option to enable/disable scanning. diff --git a/debian/changelog b/debian/changelog index 89654d8c..708a11b2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,6 +1,7 @@ openwebrx (1.2.67) bullseye jammy; urgency=low * Added keyboard shortcuts (press [?] for help). + * Added range check to the FFT overlap parameter. -- Marat Fayzullin Mon, 26 Aug 2024 16:12:00 +0000 diff --git a/owrx/controllers/settings/general.py b/owrx/controllers/settings/general.py index eb2e4608..89db5da3 100644 --- a/owrx/controllers/settings/general.py +++ b/owrx/controllers/settings/general.py @@ -161,6 +161,7 @@ class GeneralSettingsController(SettingsFormController): "FFT vertical overlap factor", infotext="If fft_voverlap_factor is above 0, multiple FFTs will be used for creating a line on the " + "diagram.", + validator=RangeValidator(0.0, 0.9), ), WaterfallLevelsInput("waterfall_levels", "Waterfall levels"), WaterfallAutoLevelsInput( diff --git a/owrx/form/input/__init__.py b/owrx/form/input/__init__.py index 494ae2f4..f7595eb6 100644 --- a/owrx/form/input/__init__.py +++ b/owrx/form/input/__init__.py @@ -161,8 +161,8 @@ class NumberInput(Input): class FloatInput(NumberInput): - def __init__(self, id, label, infotext=None, converter: Converter = None): - super().__init__(id, label, infotext, converter=converter) + def __init__(self, id, label, infotext=None, converter: Converter = None, validator: Validator = None): + super().__init__(id, label, infotext, converter=converter, validator=validator) self.step = "any" def defaultConverter(self): diff --git a/owrx/form/input/validator.py b/owrx/form/input/validator.py index bda4304d..462ec221 100644 --- a/owrx/form/input/validator.py +++ b/owrx/form/input/validator.py @@ -16,7 +16,7 @@ class RequiredValidator(Validator): class Range(object): - def __init__(self, start: int, end: int = None): + def __init__(self, start, end = None): self.start = start self.end = end if end is not None else start