olegpz
/
ericw-tools
mirror of https://github.com/ericwa/ericw-tools.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qbsp: for "Q2 phong (value set, LIGHT unset) used on a mirrored face." warning, don't set value to 0 

- setting value to 0 was not a robust way to disable phong
- it could actually have the reverse effect if "value 1" was
  being used to change a smoothing group, setting value back to 0
  could reintroduce unwanted smoothing
- that hack should be less useful with the phong system improvements
  in the previous commits
This commit is contained in:
Eric Wasylishen 2022-12-01 01:20:59 -07:00
parent f66e4790a4
commit 41de747a9a
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qbsp/map.cc
View File

@ -1653,8 +1653,7 @@ static void ParseTextureDef(parser_t &parser, mapface_t &mapface, const mapbrush
const bool mirrored = (extinfo.info->contents.native != 0)
&& !(extinfo.info->contents.native & (Q2_CONTENTS_SOLID | Q2_CONTENTS_WINDOW));
if (wants_phong && mirrored) {
logging::print("WARNING: {}: Q2 phong (value set, LIGHT unset) used on a mirrored face. Removing phong.\n", mapface.line);
extinfo.info->value = 0;
logging::print("WARNING: {}: Q2 phong (value set, LIGHT unset) used on a mirrored face.\n", mapface.line);
}
}