bspfile: add fixme about q2 overflow checking

2021-09-21 00:09:55 -06:00 · 2021-09-21 00:09:55 -06:00 · 8d51e23ecc
parent 0c0cc9ef81
commit 8d51e23ecc
1 changed files with 3 additions and 0 deletions
--- a/common/bspfile.cc
+++ b/common/bspfile.cc
@ -2716,6 +2716,9 @@ ConvertBSPFormat(bspdata_t *bspdata, const bspversion_t *to_version)
            const mbsp_t *mbsp = &bspdata->data.mbsp;
            q2bsp_t *q2bsp = &bspdata->data.q2bsp;
        
+            // FIXME: validate that the conversion is possible without overflow
+            // (see bspver_q1 case above)
+
            memset(q2bsp, 0, sizeof(*q2bsp));
        
            // copy counts