Commit Graph

1236 Commits

Author SHA1 Message Date
Heikki Hannikainen 4622369bb7 coverity: Fix a small logging bug (only log app name/ver if it's present)
Removed a lot of #ifdefs by using static username/version/addr vars always.
2013-02-03 19:06:43 +02:00
Heikki Hannikainen 6cbf13b4e6 coverity: filter: Fix resource leak 2013-02-03 18:53:08 +02:00
Heikki Hannikainen 0fbd16ab3e filter: Fix additional buffer overflows 2013-02-03 18:44:12 +02:00
Heikki Hannikainen eee9753ce6 coverity: http: use fstat() instead of stat() to make sure IMS hits
works right in the rather unlikely scenario of a static file getting
replaced during request handling.
2013-02-03 18:31:04 +02:00
Heikki Hannikainen 583c473882 accept: Check for setsockopt() return codes 2013-02-02 19:58:32 +02:00
Heikki Hannikainen 981e254873 coverity: accept: Check pass_client_to_worker return value
in case of mutex lock failure, could fail, should log
2013-02-02 19:44:53 +02:00
Heikki Hannikainen 6983f17463 coverity: xpoll epoll: Check fcntl return value, log error as necessary 2013-02-02 19:40:04 +02:00
Heikki Hannikainen 4acccebfc4 coverity: fix a minor bug in symbol parsing from destination callsign 2013-02-02 19:36:07 +02:00
Heikki Hannikainen 17a6b723ad coverity: uplink: if uplink server name resolves but returns 0
records, don't divide by zero.
2013-02-02 19:12:57 +02:00
Heikki Hannikainen 361132c518 coverity: If port is full, handle client disconnection right. 2013-02-02 19:10:10 +02:00
Heikki Hannikainen f167f9c06f coverity: worker: client classification: If it fails, don't reference null pointers. 2013-02-02 19:07:28 +02:00
Heikki Hannikainen ad3d1e9e39 fix missing comment termination 2013-02-02 19:06:25 +02:00
Heikki Hannikainen a2a1d54393 parse_aprs: add comments about intentional missing break in case 2013-02-02 19:03:25 +02:00
Heikki Hannikainen 306b25c242 coverity: Fix a potential null pointer dereference 2013-02-02 18:57:02 +02:00
Heikki Hannikainen ffefb0a6de More silencing of compiler warnings 2013-02-02 18:54:08 +02:00
Heikki Hannikainen 5c97c5a684 accept: Try to silence both a compiler warning and a coverity warning.
We really do not care if this write failed or not.
2013-02-02 18:53:15 +02:00
Heikki Hannikainen 3161760e86 coverity: filter: fix out-of-bounds access bugs in filter command processing 2013-02-02 17:08:34 +02:00
Heikki Hannikainen 233036ae20 coverity: Live upgrade: fixed a heap overrun-by-1 2013-02-02 17:00:39 +02:00
Heikki Hannikainen 6fe1f3d444 Fix small memory leak while accepting connections 2013-02-02 16:58:33 +02:00
Heikki Hannikainen 30335dbdc3 coverity: Fix a small memory leak on live upgrade 2013-02-02 16:53:33 +02:00
Heikki Hannikainen 4ffd5866f8 coverity: Fix one more memory leak which doesn't really happen 2013-02-02 16:52:07 +02:00
Heikki Hannikainen cadc63c80a coverity: "Fixed" several memory leaks which do not really happen
since the code in question is only run once at startup and once
at shutdown.
2013-02-02 16:45:16 +02:00
Heikki Hannikainen d59f73c1a4 coverity: Fix small memory leak in config reading in case of bad config 2013-02-01 09:55:54 +02:00
Heikki Hannikainen 7e6af53f5b coverity: Fix memory leak in status JSON generation in case of
rare mutex lock failure (failed to generate JSON due to memory
corruption which caused mutex lock to fail?)
2013-02-01 07:46:41 +02:00
Heikki Hannikainen c27ac87d91 coverity: Fix memory leak at live upgrade - free the buffer containing
status JSON file contents
2013-02-01 07:43:45 +02:00
Heikki Hannikainen 1778ede8d5 coverity: Fix double-free in config processing error case 2013-02-01 07:35:51 +02:00
Heikki Hannikainen ed37f32189 Classify clients only when they have logged in. Use classification
presence to determine if packets should be sent in outgoing.c, which
saves one more condition check for login status for every packet.
2013-02-01 07:33:04 +02:00
Heikki Hannikainen 1d1c0ea38c publish sleeptest.c tool 2013-01-31 14:58:01 +02:00
Heikki Hannikainen 6ac7098b5a Dupeclients: Prepend "dup\t" to outgoing dupe packets
in order to prevent regular clients from processing them.
2013-01-20 08:21:54 +02:00
Heikki Hannikainen 0203448815 On FreeBSD and other non-Linux platforms, do not incorrectly clain POSIX capabilities are available. 2013-01-19 13:05:33 +02:00
Heikki Hannikainen 6b1080b815 writepid(): Correctly check for failure to open pid file for writing 2013-01-19 12:59:19 +02:00
Heikki Hannikainen 0952ce47b6 version 1.7.7 2013-01-16 21:47:01 +02:00
Heikki Hannikainen 32ffc47a45 Fix keepalive poll frequency to manage backward time jumps.
Make it a #define for a minimal optimization.
2013-01-16 14:24:50 +02:00
Heikki Hannikainen 033d40288f worker: Only raise an alert about internal packet drops if more than
24 packets were dropped within 24 hours.
2013-01-16 14:20:45 +02:00
Heikki Hannikainen a52036f7b7 Sanitize filter strings given as a part of the login command.
Don't let invalid UTF-8 or other binary stuff go to the status JSON.
2013-01-16 14:03:32 +02:00
Heikki Hannikainen 8f6edb16ee worker: disable the "client cleanup" debug log message 2012-11-23 10:26:26 +02:00
Heikki Hannikainen fc01ba1366 munin plugin: Pull peer serverIDs to peer traffic graph 2012-11-23 10:16:51 +02:00
Heikki Hannikainen 0312148286 PeerGroup config: Ignore local address quietly to allow symmetric configs 2012-11-23 09:57:51 +02:00
Heikki Hannikainen f62eedd847 Makefile: fix rm command in clean target 2012-11-22 17:43:32 +02:00
Heikki Hannikainen fd363acd09 version 1.7.6 2012-11-22 17:41:52 +02:00
Heikki Hannikainen 26a1fff2ee dupecheck: Optimize away an unnecessary round of its main loop before sleeping. 2012-11-22 17:02:32 +02:00
Heikki Hannikainen 39f505e0d1 dupecheck: replaced a poll with a nanosleep 2012-11-22 00:38:51 +02:00
Heikki Hannikainen 144589e450 uplink: removed an extra 100m sleep with poll 2012-11-22 00:38:33 +02:00
Heikki Hannikainen 48982660ac tests: Make them run 20 seconds faster by making sleeps in tests shorter 2012-11-22 00:19:11 +02:00
Heikki Hannikainen a371e732d0 Disable eventfd usage for now. 2012-11-22 00:16:45 +02:00
Heikki Hannikainen 75d3f0bf12 version 1.7.5 2012-11-20 22:44:19 +02:00
Heikki Hannikainen 3eb21e89ef web: display peer ServerID 2012-11-20 22:35:13 +02:00
Heikki Hannikainen 4eba57d4b1 PeerGroup config: Specify remote ServerIDs before IP addresses 2012-11-20 22:15:35 +02:00
Heikki Hannikainen 74fdfadc30 udp-load test: use a smaller burst to reduce spurious failures 2012-11-20 22:15:00 +02:00
Heikki Hannikainen fa30dc6fb1 Messaging: Accept any packet as message routing hint for filtered ports,
not just position packets.
2012-11-20 22:08:09 +02:00